Qr scan #307
Open
Qr scan #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/build.gradle.kts # app/src/main/java/com/github/kr328/clash/NewProfileActivity.kt # design/src/main/java/com/github/kr328/clash/design/model/ProfileProvider.kt
wwqgtxx
requested changes
Sep 10, 2024
| @@ -18,4 +18,5 @@ dependencies { | |||
| implementation(libs.androidx.fragment) | |||
| implementation(libs.androidx.viewpager) | |||
| implementation(libs.google.material) | |||
| implementation("com.google.android.gms:play-services-code-scanner:16.1.0") | |||
There was a problem hiding this comment.
should not depend GMS, maybe https://github.com/zxing/zxing or https://github.com/G00fY2/quickie is better
or bundle the model with https://developers.google.com/ml-kit/vision/barcode-scanning/android
wwqgtxx
force-pushed
the
main
branch
2 times, most recently
from
97364a9
to
9edf35c
Compare
Larvan2
force-pushed
the
main
branch
10 times, most recently
from
e3d92ac
to
3cc77c7
Compare
yezhao88
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QR scanner function